Food vouchers complement in MX #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cavalle
commented
Oct 3, 2023
cavalle
commented
- Adds Food Vouchers complement to MX regime used to generate the CFDI's "ValesDeDespensa" complement.
- Related to the Fuel Account Balance complement (Fuel account balance complement to MX regime #210)
- The GOBL complements maps one by one to every node and field of the CFDI complement.
- Implements validations according to the constrains of the the ValesDeDespensa spec.
- Normalises all the amounts to the precision (2 decimals) specified in the ValesDeDespensa spec.
- Calculates the grand total.
samlown
reviewed
Oct 3, 2023
samlown
reviewed
Oct 3, 2023
| ) | ||
| } | ||
|
|
||
| func validateFoodVouchersEmployee(value interface{}) error { |
There was a problem hiding this comment.
BTW, you don't need to manually validate here. You just define the func (fve *FoodVoucersEmployee) Validate() error method and ensure the preceding structure includes the field definition:
validation.Field(&line.Employee),
There was a problem hiding this comment.
Nice one! Addressed in cf73168
samlown
approved these changes
Oct 4, 2023
| validation.Length(0, 20), | ||
| ), | ||
| validation.Field(&fvl.IssueDateTime, cal.DateTimeNotZero()), | ||
| validation.Field(&fvl.Employee, validation.Required), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.